Skip to content

Refresh exceptions best practices #40688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2024
Merged

Refresh exceptions best practices #40688

merged 5 commits into from
May 1, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 1, 2024 •
edited by github-actions bot
Loading

Fixes #40238.

The main article that changed is "Best practices for exceptions". Preview is here.

Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/statements/exception-handling-statements.md Exception-handling statements - throw, try-catch, try-finally, and try-catch-finally
docs/csharp/nullable-references.md Nullable reference types
docs/fundamentals/code-analysis/quality-rules/ca1065.md CA1065: Do not raise exceptions in unexpected locations
docs/fundamentals/code-analysis/quality-rules/ca2200.md docs/fundamentals/code-analysis/quality-rules/ca2200
docs/fundamentals/code-analysis/quality-rules/ca2208.md CA2208: Instantiate argument exceptions correctly
docs/fundamentals/code-analysis/quality-rules/index.md Code quality rules overview
docs/standard/exceptions/best-practices-for-exceptions.md Best practices for exceptions
docs/standard/exceptions/how-to-use-finally-blocks.md How to use finally blocks

@dotnet-bot dotnet-bot added this to the May 2024 milestone May 1, 2024
@gewarren
Copy link
Contributor Author

gewarren commented May 1, 2024

@stephentoub If you have time to review the updated "Best practices for exceptions" article, that would be great. The preview is here.

BillWagner
BillWagner approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

stephentoub
stephentoub reviewed May 1, 2024
View reviewed changes
@gewarren
Copy link
Contributor Author

gewarren commented May 1, 2024

Thanks @stephentoub!

@gewarren gewarren enabled auto-merge (squash) May 1, 2024 20:32
@gewarren gewarren merged commit 81dcd72 into dotnet:main May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@stephentoub stephentoub stephentoub approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees

No one assigned

Labels

dotnet-csharp/svc dotnet-fundamentals/svc lang-reference/subsvc

Projects

None yet

Milestone

May 2024

Development

Successfully merging this pull request may close these issues.

Improve freshness for top 10 articles

4 participants

@gewarren @BillWagner @stephentoub @dotnet-bot